Files
arcadia-admin/app/routes/memberships.tsx
jules 7415b40240 Admin UX overhaul: P0 fixes, error-UX foundations, nav cleanup, tenant detail page
From the 2026-07-14 UI/UX audit (17/40). Four phases:

P1 — Settings route crashed on Agents→Edit (Input/Textarea used but never
imported). Added imports + a shared route-level error boundary
(components/route-error.tsx) re-exported from all shell routes, so one
crashing panel degrades to an explained card with the nav intact instead of
replacing the whole app with a stack trace. Corrected the stale CLAUDE.md
claim that `npm run typecheck` crashes — it works, and would have caught the
missing import.

P2 — Error/empty/feedback foundations. Fixed useSession identity churn that
fired ~3x duplicate fetches per screen and self-inflicted 429s (referentially
stable snapshot). New lib/errors.ts (describeError → plain-language + the fix)
and components/data-state.tsx (DataState renders exactly one of
error/loading/empty/content, so a failed load never shows as "empty";
DialogError for in-dialog failures; 429 auto-retry). Rolled across all 15
list routes; every mutation now toasts. Surfaced+fixed two silent-failure
bugs (sso + buckets-CORS swallowed load errors; the latter could wipe rules
on save).

P3 — Nav IA + trust cleanup. Default-expanded rail; regrouped into 7 coherent
sections; collapsed the Apps/Plan/Entitlements stub triplication into one
honest /billing page; deleted fabricated seeded notifications and the dead
Help menu item; fixed the 403 copy (referenced a tenant switcher that doesn't
exist); removed orphan /assistant + /library routes; gated dev-seed login
hints behind DEV; renamed /activity → /audit-log with a redirect.

P4 — Tenant detail page (routes/tenants.$id.tsx + components/tenant-detail/*),
closing the provision→configure gap. 8 tabs (Overview, Plan & quotas,
Branding, Localization, Email & SMS, Feature flags, IP rules, Inbound
webhooks), each verified saving to the real backend. Row name links to detail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 13:43:57 +10:00

650 lines
20 KiB
TypeScript

import { useCallback, useEffect, useMemo, useState } from "react"
import {
CheckCircle2,
Network,
Pause,
Play,
Plus,
RefreshCw,
Trash2,
} from "lucide-react"
import { useArcadiaClient } from "@crema/arcadia-core-client"
import { useToast } from "@crema/notification-ui"
import {
ActionsCell,
BadgeCell,
DataTable,
DateCell,
Pagination,
useTable,
type ActionItem,
type BadgeTone,
type Column,
} from "@crema/table-ui"
import { SearchInput } from "@crema/search-ui"
import { ConfirmDialog, EmptyState } from "@crema/feedback-ui"
import { AppShell } from "~/components/layout/app-shell"
import { DataState, DialogError } from "~/components/data-state"
import { errorMessage } from "~/lib/errors"
import { Badge } from "~/components/ui/badge"
import { Button } from "~/components/ui/button"
import { Card, CardContent, CardHeader } from "~/components/ui/card"
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "~/components/ui/dialog"
import { Label } from "~/components/ui/label"
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "~/components/ui/select"
import {
activateMembership,
createMembership,
deleteMembership,
listMemberships,
suspendMembership,
updateMembership,
type Membership,
type MembershipStatus,
} from "~/lib/arcadia/memberships"
import { listUsers, type User } from "~/lib/arcadia/users"
import { listRoles, type Role } from "~/lib/arcadia/roles"
import { pageTitle } from "~/lib/page-meta"
import { useSession } from "~/lib/session"
import { useRegisterContext } from "@crema/aifirst-ui/context"
export const meta = () => pageTitle("Memberships")
type Editor =
| { kind: "create" }
| { kind: "edit"; membership: Membership }
| null
/** Who the membership is for, in the operator's words. */
function memberLabel(m: Membership): string {
return m.user?.email ?? m.user_id.slice(0, 8) + "…"
}
export default function MembershipsRoute() {
const session = useSession()
const arcadia = useArcadiaClient()
const toast = useToast()
const [memberships, setMemberships] = useState<Membership[]>([])
const [users, setUsers] = useState<User[]>([])
const [roles, setRoles] = useState<Role[]>([])
const [loading, setLoading] = useState(true)
// Raw thrown value — DataState turns the status code into plain language.
const [error, setError] = useState<unknown>(null)
const [search, setSearch] = useState("")
const [statusFilter, setStatusFilter] = useState<"all" | MembershipStatus>("all")
const [editor, setEditor] = useState<Editor>(null)
const [pendingDelete, setPendingDelete] = useState<Membership | null>(null)
const refresh = useCallback(async () => {
setError(null)
setLoading(true)
try {
// Users and roles are only needed to populate the editor's pickers; a
// failure there shouldn't blank the table, so they degrade to empty.
const [m, u, r] = await Promise.all([
listMemberships(arcadia),
listUsers(arcadia).catch(() => [] as User[]),
listRoles(arcadia).catch(() => [] as Role[]),
])
setMemberships(m)
setUsers(u)
setRoles(r)
} catch (err) {
setError(err)
} finally {
setLoading(false)
}
}, [arcadia])
useEffect(() => {
if (session) refresh()
}, [session, refresh])
const filtered = useMemo(
() =>
statusFilter === "all"
? memberships
: memberships.filter((m) => m.status === statusFilter),
[memberships, statusFilter],
)
const columns = useMemo<Column<Membership>[]>(
() => [
{
id: "user",
header: "User",
accessor: (m) => m.user?.email ?? m.user_id,
sortable: true,
cell: (m) => (
<div className="flex flex-col">
<span className="text-sm font-medium">{m.user?.email ?? "—"}</span>
<span className="text-xs text-muted-foreground">
{m.user?.first_name || m.user?.last_name
? `${m.user?.first_name ?? ""} ${m.user?.last_name ?? ""}`.trim()
: m.user_id.slice(0, 8) + "…"}
</span>
</div>
),
},
{
id: "tenant",
header: "Tenant",
accessor: (m) => m.tenant?.name ?? "",
sortable: true,
cell: (m) =>
m.tenant ? (
<div className="flex flex-col">
<span className="text-sm font-medium">{m.tenant.name}</span>
<code className="rounded bg-muted px-1 font-mono text-[10px] text-muted-foreground">
{m.tenant.slug}
</code>
</div>
) : (
<span className="text-muted-foreground"></span>
),
},
{
id: "status",
header: "Status",
accessor: "status",
sortable: true,
cell: (m) => <BadgeCell label={m.status} tone={statusTone(m.status)} />,
},
{
id: "primary",
header: "Primary",
accessor: "is_primary",
sortable: true,
cell: (m) =>
m.is_primary ? (
<CheckCircle2 className="size-4 text-emerald-500" />
) : (
<span className="text-muted-foreground"></span>
),
},
{
id: "roles",
header: "Roles",
cell: (m) =>
m.roles.length === 0 ? (
<span className="text-muted-foreground"></span>
) : (
<div className="flex flex-wrap gap-1">
{m.roles.map((r) => (
<Badge key={r.id} variant="secondary" className="font-mono text-xs">
{r.slug}
</Badge>
))}
</div>
),
},
{
id: "joined",
header: "Joined",
accessor: "joined_at",
sortable: true,
cell: (m) =>
m.joined_at ? (
<DateCell value={m.joined_at} format="short" />
) : (
<span className="text-muted-foreground"></span>
),
},
{
id: "actions",
header: "",
align: "right",
cell: (m) => {
const who = memberLabel(m)
const items: ActionItem[] = [
{
id: "edit",
label: "Edit",
dataAction: `membership-${m.id}-edit`,
onSelect: () => setEditor({ kind: "edit", membership: m }),
},
m.status === "active"
? {
id: "suspend",
label: "Suspend",
icon: <Pause className="size-4" />,
dataAction: `membership-${m.id}-suspend`,
onSelect: async () => {
try {
await suspendMembership(arcadia, m.id)
await refresh()
toast.success(`Suspended ${who}`)
} catch (err) {
toast.error(errorMessage(err, `suspend ${who}`))
}
},
}
: {
id: "activate",
label: "Activate",
icon: <Play className="size-4" />,
dataAction: `membership-${m.id}-activate`,
onSelect: async () => {
try {
await activateMembership(arcadia, m.id)
await refresh()
toast.success(`Activated ${who}`)
} catch (err) {
toast.error(errorMessage(err, `activate ${who}`))
}
},
},
{
id: "delete",
label: "Remove",
icon: <Trash2 className="size-4" />,
destructive: true,
dataAction: `membership-${m.id}-delete`,
onSelect: () => setPendingDelete(m),
},
]
return (
<ActionsCell items={items} triggerDataAction={`membership-${m.id}-actions`} />
)
},
},
],
[arcadia, refresh, toast],
)
const summary = useMemo(
() => ({
total: memberships.length,
byStatus: countBy(memberships, (m) => m.status),
uniqueTenants: new Set(memberships.map((m) => m.tenant_id)).size,
uniqueUsers: new Set(memberships.map((m) => m.user_id)).size,
}),
[memberships],
)
useRegisterContext("memberships", summary)
const table = useTable<Membership>({
data: filtered,
columns,
getRowId: (m) => m.id,
initialPageSize: 25,
initialSearch: search,
})
useEffect(() => {
table.setSearch(search)
}, [search, table])
return (
<AppShell>
<div className="flex flex-col gap-4">
<header className="flex flex-col gap-2 sm:flex-row sm:items-center sm:justify-between">
<div>
<h1 className="text-2xl font-semibold tracking-tight">Memberships</h1>
<p className="text-sm text-muted-foreground">
Who belongs to which tenant. A user can have memberships in multiple tenants;
one is marked primary.
</p>
</div>
<div className="flex items-center gap-2">
<Button
variant="outline"
size="sm"
onClick={refresh}
disabled={loading}
data-action="memberships-refresh"
>
<RefreshCw className={`size-4 ${loading ? "animate-spin" : ""}`} />
Refresh
</Button>
<Button
size="sm"
onClick={() => setEditor({ kind: "create" })}
data-action="memberships-create"
>
<Plus className="size-4" />
Add member
</Button>
</div>
</header>
<Card>
<CardHeader className="flex flex-row items-center gap-3">
<SearchInput
value={search}
onValueChange={setSearch}
placeholder="Search by user, tenant, or role"
data-action="memberships-search"
className="max-w-sm flex-1"
/>
<Select
value={statusFilter}
onValueChange={(v) => setStatusFilter(v as typeof statusFilter)}
>
<SelectTrigger className="w-40" data-action="memberships-status-filter">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All statuses</SelectItem>
<SelectItem value="active">Active</SelectItem>
<SelectItem value="suspended">Suspended</SelectItem>
<SelectItem value="deactivated">Deactivated</SelectItem>
</SelectContent>
</Select>
<div className="ml-auto text-xs text-muted-foreground">
{table.total} of {memberships.length}
</div>
</CardHeader>
<CardContent className="relative p-0">
<DataState
loading={loading}
error={error}
isEmpty={table.total === 0}
onRetry={refresh}
loadingLabel="Loading memberships…"
empty={
<EmptyState
icon={<Network className="size-6" />}
title={
search || statusFilter !== "all"
? "No memberships match those filters."
: "No memberships yet."
}
description={
search || statusFilter !== "all"
? "Loosen the filter set."
: "Add a user to a tenant to create the first membership."
}
className="py-12"
/>
}
>
<DataTable
columns={columns}
rows={table.pageRows}
getRowId={(m) => m.id}
sort={table.sort}
onSortToggle={table.toggleSort}
loading={loading && memberships.length > 0}
stickyHeader
/>
<Pagination
page={table.page}
pageSize={table.pageSize}
total={table.total}
onPageChange={table.setPage}
onPageSizeChange={table.setPageSize}
/>
</DataState>
</CardContent>
</Card>
</div>
<ConfirmDialog
open={pendingDelete !== null}
onOpenChange={(o) => !o && setPendingDelete(null)}
title="Remove membership?"
description={
pendingDelete
? `${memberLabel(pendingDelete)} immediately loses access to ${pendingDelete.tenant?.name ?? "this tenant"}, along with any roles they hold there. Suspend instead if this is temporary.`
: ""
}
confirmLabel="Remove"
variant="danger"
onConfirm={async () => {
if (!pendingDelete) return
const who = memberLabel(pendingDelete)
const where = pendingDelete.tenant?.name ?? "this tenant"
try {
await deleteMembership(arcadia, pendingDelete.id)
setPendingDelete(null)
await refresh()
toast.success(`Removed ${who} from ${where}`)
} catch (err) {
setPendingDelete(null)
toast.error(errorMessage(err, `remove ${who} from ${where}`))
}
}}
/>
<MembershipEditorDialog
state={editor}
users={users}
roles={roles}
existingUserIds={new Set(memberships.map((m) => m.user_id))}
onClose={() => setEditor(null)}
onSaved={async (message) => {
setEditor(null)
await refresh()
toast.success(message)
}}
/>
</AppShell>
)
}
function statusTone(s: MembershipStatus): BadgeTone {
if (s === "active") return "success"
if (s === "suspended") return "warning"
return "default"
}
function MembershipEditorDialog({
state,
users,
roles,
existingUserIds,
onClose,
onSaved,
}: {
state: Editor
users: User[]
roles: Role[]
existingUserIds: Set<string>
onClose: () => void
onSaved: (message: string) => Promise<void>
}) {
const arcadia = useArcadiaClient()
const open = state !== null
const isEdit = state?.kind === "edit"
const initial = isEdit ? state.membership : null
const [userId, setUserId] = useState("")
const [status, setStatus] = useState<MembershipStatus>("active")
const [selectedRoles, setSelectedRoles] = useState<Set<string>>(new Set())
const [saving, setSaving] = useState(false)
// Rendered inside the dialog: a page banner would sit behind the scrim.
const [error, setError] = useState<unknown>(null)
useEffect(() => {
if (!open) return
setError(null)
setSaving(false)
if (initial) {
setUserId(initial.user_id)
setStatus(initial.status)
setSelectedRoles(new Set(initial.roles.map((r) => r.id)))
} else {
setUserId("")
setStatus("active")
setSelectedRoles(new Set())
}
}, [open, initial])
const eligibleUsers = useMemo(
() => (isEdit ? users : users.filter((u) => !existingUserIds.has(u.id))),
[users, existingUserIds, isEdit],
)
const submit = async () => {
setError(null)
setSaving(true)
try {
const input = {
user_id: userId,
status,
role_ids: Array.from(selectedRoles),
}
const who =
users.find((u) => u.id === userId)?.email ?? initial?.user?.email ?? "the member"
if (isEdit && initial) {
await updateMembership(arcadia, initial.id, input)
await onSaved(`Saved ${who}'s membership`)
} else {
await createMembership(arcadia, input)
await onSaved(`Added ${who}`)
}
} catch (err) {
// Form state survives so the operator can fix and resubmit.
setError(err)
setSaving(false)
}
}
return (
<Dialog open={open} onOpenChange={(o) => !o && onClose()}>
<DialogContent className="sm:max-w-md">
<DialogHeader>
<DialogTitle>{isEdit ? "Edit membership" : "Add member"}</DialogTitle>
<DialogDescription>
{isEdit
? "Update status and role assignments."
: "Pick a user and assign roles within the current tenant."}
</DialogDescription>
</DialogHeader>
<div className="flex flex-col gap-3">
<div className="flex flex-col gap-1.5">
<Label>User</Label>
<Select value={userId} onValueChange={setUserId} disabled={isEdit}>
<SelectTrigger data-action="membership-form-user">
<SelectValue placeholder="Pick a user" />
</SelectTrigger>
<SelectContent>
{eligibleUsers.length === 0 ? (
<SelectItem value="__none" disabled>
No eligible users
</SelectItem>
) : (
eligibleUsers.map((u) => (
<SelectItem key={u.id} value={u.id}>
{u.email}
</SelectItem>
))
)}
</SelectContent>
</Select>
</div>
<div className="flex flex-col gap-1.5">
<Label>Status</Label>
<Select
value={status}
onValueChange={(v) => setStatus(v as MembershipStatus)}
>
<SelectTrigger data-action="membership-form-status">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="active">Active</SelectItem>
<SelectItem value="suspended">Suspended</SelectItem>
<SelectItem value="deactivated">Deactivated</SelectItem>
</SelectContent>
</Select>
</div>
<div className="flex flex-col gap-1.5">
<Label>Roles</Label>
{roles.length === 0 ? (
<p className="text-xs text-muted-foreground">
No roles defined. Create some on the Users tab.
</p>
) : (
<div className="flex flex-wrap gap-1.5 rounded-md border p-2">
{roles.map((r) => {
const active = selectedRoles.has(r.id)
return (
<button
key={r.id}
type="button"
onClick={() => {
setSelectedRoles((prev) => {
const next = new Set(prev)
if (next.has(r.id)) next.delete(r.id)
else next.add(r.id)
return next
})
}}
data-action={`membership-form-role-${r.slug}`}
className={[
"rounded-full border px-2.5 py-1 text-xs font-medium transition-colors",
active
? "border-primary bg-primary/10 text-primary"
: "border-border text-muted-foreground hover:bg-accent",
].join(" ")}
>
{r.name}
</button>
)
})}
</div>
)}
</div>
</div>
{error ? (
<DialogError
error={error}
context={isEdit ? "save the membership" : "add the member"}
/>
) : null}
<DialogFooter>
<Button
variant="outline"
onClick={onClose}
disabled={saving}
data-action="membership-form-cancel"
>
Cancel
</Button>
<Button
onClick={submit}
disabled={saving || !userId}
data-action="membership-form-save"
>
{saving ? <RefreshCw className="size-4 animate-spin" /> : <CheckCircle2 className="size-4" />}
{isEdit ? "Save" : "Add"}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
)
}
function countBy<T>(arr: T[], key: (x: T) => string): Record<string, number> {
return arr.reduce<Record<string, number>>((acc, x) => {
const k = key(x)
acc[k] = (acc[k] ?? 0) + 1
return acc
}, {})
}
export { RouteErrorBoundary as ErrorBoundary } from "~/components/route-error"