Files
arcadia-admin/app/routes/tenants.tsx
jules 7415b40240 Admin UX overhaul: P0 fixes, error-UX foundations, nav cleanup, tenant detail page
From the 2026-07-14 UI/UX audit (17/40). Four phases:

P1 — Settings route crashed on Agents→Edit (Input/Textarea used but never
imported). Added imports + a shared route-level error boundary
(components/route-error.tsx) re-exported from all shell routes, so one
crashing panel degrades to an explained card with the nav intact instead of
replacing the whole app with a stack trace. Corrected the stale CLAUDE.md
claim that `npm run typecheck` crashes — it works, and would have caught the
missing import.

P2 — Error/empty/feedback foundations. Fixed useSession identity churn that
fired ~3x duplicate fetches per screen and self-inflicted 429s (referentially
stable snapshot). New lib/errors.ts (describeError → plain-language + the fix)
and components/data-state.tsx (DataState renders exactly one of
error/loading/empty/content, so a failed load never shows as "empty";
DialogError for in-dialog failures; 429 auto-retry). Rolled across all 15
list routes; every mutation now toasts. Surfaced+fixed two silent-failure
bugs (sso + buckets-CORS swallowed load errors; the latter could wipe rules
on save).

P3 — Nav IA + trust cleanup. Default-expanded rail; regrouped into 7 coherent
sections; collapsed the Apps/Plan/Entitlements stub triplication into one
honest /billing page; deleted fabricated seeded notifications and the dead
Help menu item; fixed the 403 copy (referenced a tenant switcher that doesn't
exist); removed orphan /assistant + /library routes; gated dev-seed login
hints behind DEV; renamed /activity → /audit-log with a redirect.

P4 — Tenant detail page (routes/tenants.$id.tsx + components/tenant-detail/*),
closing the provision→configure gap. 8 tabs (Overview, Plan & quotas,
Branding, Localization, Email & SMS, Feature flags, IP rules, Inbound
webhooks), each verified saving to the real backend. Row name links to detail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 13:43:57 +10:00

594 lines
18 KiB
TypeScript

import { useCallback, useEffect, useMemo, useState, type FormEvent } from "react"
import { Link, useNavigate } from "react-router"
import { Pause, Play, Plus, RefreshCw, Settings2 } from "lucide-react"
import { useArcadiaClient } from "@crema/arcadia-core-client"
import { useToast } from "@crema/notification-ui"
import {
ActionsCell,
BadgeCell,
DataTable,
DateCell,
Pagination,
useTable,
type ActionItem,
type BadgeTone,
type Column,
} from "@crema/table-ui"
import { SearchInput } from "@crema/search-ui"
import { ConfirmDialog, EmptyState } from "@crema/feedback-ui"
import { AppShell } from "~/components/layout/app-shell"
import { DataState, DialogError } from "~/components/data-state"
import { PageHeader } from "~/components/layout/page-header"
import { errorMessage } from "~/lib/errors"
import { Button } from "~/components/ui/button"
import {
Card,
CardContent,
CardDescription,
CardHeader,
CardTitle,
} from "~/components/ui/card"
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "~/components/ui/dialog"
import { Input } from "~/components/ui/input"
import { Label } from "~/components/ui/label"
import {
activateTenant,
deactivateTenant,
listTenants,
provisionTenant,
suspendTenant,
type Tenant,
type TenantStatus,
} from "~/lib/arcadia/tenants"
import { pageTitle } from "~/lib/page-meta"
import { useSession } from "~/lib/session"
import { useRegisterContext } from "@crema/aifirst-ui/context"
export const meta = () => pageTitle("Tenants")
type PendingAction = {
kind: "suspend" | "deactivate"
tenant: Tenant
} | null
export default function TenantsRoute() {
const session = useSession()
const arcadia = useArcadiaClient()
const toast = useToast()
const navigate = useNavigate()
const [tenants, setTenants] = useState<Tenant[]>([])
const [loading, setLoading] = useState(true)
// The raw thrown value — `DataState` normalises it into plain language. We
// deliberately don't stringify here; the status code carries the meaning.
const [error, setError] = useState<unknown>(null)
const [pending, setPending] = useState<PendingAction>(null)
const [search, setSearch] = useState("")
const [createOpen, setCreateOpen] = useState(false)
const refresh = useCallback(async () => {
setError(null)
setLoading(true)
try {
const list = await listTenants(arcadia)
setTenants(list)
} catch (err) {
setError(err)
} finally {
setLoading(false)
}
}, [arcadia])
useEffect(() => {
if (session) refresh()
}, [session, refresh])
const runAction = useCallback(
async (action: PendingAction) => {
if (!action) return
const verb = action.kind === "suspend" ? "Suspended" : "Deactivated"
try {
if (action.kind === "suspend") await suspendTenant(arcadia, action.tenant.id)
else await deactivateTenant(arcadia, action.tenant.id)
setPending(null)
await refresh()
toast.success(`${verb} ${action.tenant.name}`)
} catch (err) {
setPending(null)
toast.error(errorMessage(err, `${action.kind} ${action.tenant.name}`))
}
},
[arcadia, refresh, toast],
)
const columns = useMemo<Column<Tenant>[]>(
() => [
{
id: "name",
header: "Name",
accessor: "name",
sortable: true,
cell: (t) => (
<Link
to={`/tenants/${t.id}`}
className="font-medium hover:underline"
data-action={`tenant-${t.slug}-open`}
>
{t.name}
</Link>
),
},
{
id: "slug",
header: "Slug",
accessor: "slug",
sortable: true,
cell: (t) => (
<code className="rounded bg-muted px-1.5 py-0.5 font-mono text-xs">{t.slug}</code>
),
},
{
id: "status",
header: "Status",
accessor: "status",
sortable: true,
cell: (t) => <BadgeCell label={t.status} tone={statusTone(t.status)} />,
},
{
id: "plan",
header: "Plan",
accessor: (t) => t.plan?.name ?? "",
sortable: true,
cell: (t) => <span className="text-muted-foreground">{t.plan?.name ?? "—"}</span>,
},
{
id: "created",
header: "Created",
accessor: "inserted_at",
sortable: true,
cell: (t) => <DateCell value={t.inserted_at} format="short" />,
},
{
id: "actions",
header: "",
align: "right",
cell: (t) => (
<ActionsCell
items={rowActions(t, arcadia, refresh, setPending, toast, navigate)}
triggerDataAction={`tenant-${t.slug}-actions`}
/>
),
},
],
[arcadia, refresh, toast, navigate],
)
const tenantSummary = useMemo(
() => ({
total: tenants.length,
byStatus: tenants.reduce<Record<string, number>>((acc, t) => {
acc[t.status] = (acc[t.status] ?? 0) + 1
return acc
}, {}),
tenants: tenants.map((t) => ({
id: t.id,
slug: t.slug,
name: t.name,
status: t.status,
plan: t.plan?.name ?? null,
inserted_at: t.inserted_at,
})),
}),
[tenants],
)
useRegisterContext("tenants", tenantSummary)
const table = useTable<Tenant>({
data: tenants,
columns,
getRowId: (t) => t.id,
initialPageSize: 25,
initialSearch: search,
})
// Keep useTable's search in lockstep with our SearchInput.
useEffect(() => {
table.setSearch(search)
}, [search, table])
return (
<AppShell>
<PageHeader
title="Tenants"
description="Multi-tenant workspaces on this arcadia deployment."
actions={
<>
<Button
variant="outline"
size="sm"
onClick={refresh}
disabled={loading}
data-action="tenants-refresh"
>
<RefreshCw className={`size-4 ${loading ? "animate-spin" : ""}`} />
Refresh
</Button>
<Button
size="sm"
onClick={() => setCreateOpen(true)}
data-action="tenants-create"
>
<Plus className="size-4" />
New tenant
</Button>
</>
}
/>
<Card>
<CardHeader className="flex flex-row items-center justify-between gap-4">
<SearchInput
value={search}
onValueChange={setSearch}
placeholder="Search by name, slug, or status"
data-action="tenants-search"
className="max-w-sm flex-1"
/>
<div className="text-xs text-muted-foreground">
{table.total} of {tenants.length}
</div>
</CardHeader>
<CardContent className="relative p-0">
<DataState
loading={loading}
error={error}
isEmpty={table.total === 0}
onRetry={refresh}
loadingLabel="Loading tenants…"
empty={
<EmptyState
title={search ? "No tenants match that search." : "No tenants yet."}
description={
search
? "Try a different name, slug, or status."
: "Create your first tenant to get started."
}
className="py-12"
/>
}
>
<DataTable
columns={columns}
rows={table.pageRows}
getRowId={(t) => t.id}
sort={table.sort}
onSortToggle={table.toggleSort}
loading={loading && tenants.length > 0}
stickyHeader
/>
<Pagination
page={table.page}
pageSize={table.pageSize}
total={table.total}
onPageChange={table.setPage}
onPageSizeChange={table.setPageSize}
/>
</DataState>
</CardContent>
</Card>
<TenantCreateDialog
open={createOpen}
onClose={() => setCreateOpen(false)}
onCreated={async (tenant, adminEmail) => {
setCreateOpen(false)
await refresh()
// The money moment. Say what happened and what the operator can do
// next — previously the dialog just closed with no confirmation at all.
toast.success(`Tenant "${tenant.name}" created`, {
description: `${adminEmail} can now sign in with tenant ID "${tenant.slug}".`,
})
}}
/>
<ConfirmDialog
open={pending?.kind === "suspend"}
onOpenChange={(o) => !o && setPending(null)}
title="Suspend tenant?"
description={
pending
? `${pending.tenant.name} will be suspended. Members won't be able to sign in until you reactivate.`
: ""
}
confirmLabel="Suspend"
variant="default"
onConfirm={() => runAction(pending)}
/>
<ConfirmDialog
open={pending?.kind === "deactivate"}
onOpenChange={(o) => !o && setPending(null)}
title="Deactivate tenant?"
description={
pending
? `${pending.tenant.name} will be taken offline: nobody can sign in, and its apps stop serving. Its data is kept, and you can reactivate it from this table. Suspend instead if this is temporary.`
: ""
}
confirmLabel="Deactivate"
variant="danger"
onConfirm={() => runAction(pending)}
/>
</AppShell>
)
}
function statusTone(status: TenantStatus): BadgeTone {
if (status === "active") return "success"
if (status === "suspended") return "warning"
if (status === "deactivated") return "danger"
return "default"
}
function rowActions(
t: Tenant,
arcadia: ReturnType<typeof useArcadiaClient>,
refresh: () => Promise<void>,
setPending: (p: PendingAction) => void,
toast: ReturnType<typeof useToast>,
navigate: (to: string) => void,
): ActionItem[] {
const items: ActionItem[] = [
{
id: "manage",
label: "Manage",
icon: <Settings2 className="size-4" />,
dataAction: `tenant-${t.slug}-manage`,
onSelect: () => navigate(`/tenants/${t.id}`),
},
]
if (t.status === "active") {
items.push({
id: "suspend",
label: "Suspend",
icon: <Pause className="size-4" />,
dataAction: `tenant-${t.slug}-suspend`,
onSelect: () => setPending({ kind: "suspend", tenant: t }),
})
} else {
items.push({
id: "activate",
label: "Activate",
icon: <Play className="size-4" />,
dataAction: `tenant-${t.slug}-activate`,
onSelect: async () => {
try {
await activateTenant(arcadia, t.id)
await refresh()
toast.success(`Activated ${t.name}`)
} catch (err) {
toast.error(errorMessage(err, `activate ${t.name}`))
}
},
})
}
items.push({
id: "deactivate",
label: "Deactivate",
destructive: true,
dataAction: `tenant-${t.slug}-deactivate`,
onSelect: () => setPending({ kind: "deactivate", tenant: t }),
})
return items
}
function slugify(name: string): string {
return name
.toLowerCase()
.trim()
.replace(/[^a-z0-9]+/g, "-")
.replace(/^-+|-+$/g, "")
}
function TenantCreateDialog({
open,
onClose,
onCreated,
}: {
open: boolean
onClose: () => void
onCreated: (tenant: Tenant, adminEmail: string) => Promise<void> | void
}) {
const arcadia = useArcadiaClient()
const [name, setName] = useState("")
const [slug, setSlug] = useState("")
const [slugDirty, setSlugDirty] = useState(false)
const [firstName, setFirstName] = useState("")
const [lastName, setLastName] = useState("")
const [email, setEmail] = useState("")
const [password, setPassword] = useState("")
const [submitting, setSubmitting] = useState(false)
// Errors belong to the dialog, not the page. They used to be hoisted to a
// page-level banner that rendered *behind* the modal scrim — dimmed, above
// the fold, and unreadable — so a failed provision looked like nothing
// happened at all.
const [error, setError] = useState<unknown>(null)
useEffect(() => {
if (!open) {
setName("")
setSlug("")
setSlugDirty(false)
setFirstName("")
setLastName("")
setEmail("")
setPassword("")
setSubmitting(false)
setError(null)
}
}, [open])
const slugInvalid = slug.length > 0 && !/^[a-z0-9-]+$/.test(slug)
const canSubmit =
!submitting &&
name.trim().length > 0 &&
slug.length > 0 &&
!slugInvalid &&
firstName.trim().length > 0 &&
lastName.trim().length > 0 &&
email.trim().length > 0 &&
password.length >= 8
async function handleSubmit(e: FormEvent) {
e.preventDefault()
if (!canSubmit) return
setSubmitting(true)
setError(null)
try {
const tenant = await provisionTenant(arcadia, {
tenant: { name: name.trim(), slug },
admin_user: {
email: email.trim(),
password,
first_name: firstName.trim(),
last_name: lastName.trim(),
},
})
await onCreated(tenant, email.trim())
} catch (err) {
// Keep the dialog open with the form intact so the operator can fix and
// resubmit without retyping.
setError(err)
setSubmitting(false)
}
}
return (
<Dialog open={open} onOpenChange={(o) => !o && onClose()}>
<DialogContent className="sm:max-w-lg">
<form onSubmit={handleSubmit}>
<DialogHeader>
<DialogTitle>New tenant</DialogTitle>
<DialogDescription>
Creates the tenant with its system roles and an initial admin user who can
sign in straight away.
</DialogDescription>
</DialogHeader>
<div className="space-y-4 py-4">
<div className="space-y-2">
<Label htmlFor="tenant-name">Tenant name</Label>
<Input
id="tenant-name"
value={name}
onChange={(e) => {
setName(e.target.value)
if (!slugDirty) setSlug(slugify(e.target.value))
}}
placeholder="Acme Corp"
autoFocus
data-action="tenants-create-name"
/>
</div>
<div className="space-y-2">
<Label htmlFor="tenant-slug">Slug</Label>
<Input
id="tenant-slug"
value={slug}
onChange={(e) => {
setSlugDirty(true)
setSlug(e.target.value)
}}
placeholder="acme"
data-action="tenants-create-slug"
/>
<p className="text-xs text-muted-foreground">
{slugInvalid
? "Lowercase letters, digits, and hyphens only."
: "Lowercase letters, digits, and hyphens. Used in URLs and the X-Tenant-ID header."}
</p>
</div>
<div className="grid grid-cols-2 gap-3">
<div className="space-y-2">
<Label htmlFor="tenant-admin-first-name">Admin first name</Label>
<Input
id="tenant-admin-first-name"
value={firstName}
onChange={(e) => setFirstName(e.target.value)}
placeholder="Jane"
data-action="tenants-create-admin-first-name"
/>
</div>
<div className="space-y-2">
<Label htmlFor="tenant-admin-last-name">Admin last name</Label>
<Input
id="tenant-admin-last-name"
value={lastName}
onChange={(e) => setLastName(e.target.value)}
placeholder="Doe"
data-action="tenants-create-admin-last-name"
/>
</div>
</div>
<div className="space-y-2">
<Label htmlFor="tenant-admin-email">Admin email</Label>
<Input
id="tenant-admin-email"
type="email"
value={email}
onChange={(e) => setEmail(e.target.value)}
placeholder="admin@acme.com"
data-action="tenants-create-admin-email"
/>
</div>
<div className="space-y-2">
<Label htmlFor="tenant-admin-password">Admin password</Label>
<Input
id="tenant-admin-password"
type="password"
value={password}
onChange={(e) => setPassword(e.target.value)}
placeholder="At least 8 characters"
data-action="tenants-create-admin-password"
/>
</div>
</div>
{error ? <DialogError error={error} context="create the tenant" /> : null}
<DialogFooter>
<Button
type="button"
variant="outline"
onClick={onClose}
disabled={submitting}
data-action="tenants-create-cancel"
>
Cancel
</Button>
<Button
type="submit"
disabled={!canSubmit}
data-action="tenants-create-submit"
>
{submitting ? "Creating…" : "Create tenant"}
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
)
}
export { RouteErrorBoundary as ErrorBoundary } from "~/components/route-error"